feat: rebind masked variables #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here improved creating variables to override deeper bindings when new variable overrides ancestor variable. Here's a video with example
kof
approved these changes
Feb 9, 2025
|
Hey I'm seeing variable IDs output. Am I doing something wrong? Thought we got rid of those. Seems like something is wrong... I think I would expect only one "hello" to show up as the second overrides the first but in my video I see both and can select them independently. nested.mp4 |
|
Good catch! |
johnsicili
approved these changes
Feb 9, 2025
|
Will fix it in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here improved creating variables to override deeper bindings when new variable overrides ancestor variable similar to css variables behavior.
Here's a video with example
Screen.Recording.2025-02-09.at.16.10.16.mov