Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve redirect error message #4831

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: Improve redirect error message #4831

merged 1 commit into from
Feb 4, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 4, 2025

Description

Discussion

image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from johnsicili February 4, 2025 14:17
@kof kof merged commit 09a1ecd into main Feb 4, 2025
17 checks passed
@kof kof deleted the redirect-error branch February 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@johnsicili johnsicili Awaiting requested review from johnsicili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @TrySound