Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Focus mode for style panel #4827

Merged
merged 2 commits into from
Feb 4, 2025
Merged

experimental: Focus mode for style panel #4827

merged 2 commits into from
Feb 4, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 4, 2025

#4816

Description

Still behind a flag, so on dev only, but now style panel is in accordion mode. Switch will come next.

Testing:

In this mode only one section at a time will be open and Layout is the initial one.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound February 4, 2025 10:20
@kof kof changed the title experimental: Accordion mode for style panel experimental: Focus mode for style panel Feb 4, 2025
Copy link
Member

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test

@kof kof merged commit 5ad5a71 into main Feb 4, 2025
19 checks passed
@kof kof deleted the sp-modes branch February 4, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants