feat: allow saving expressions with unset variables #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #4768 #4753 User can paste expression with not defined variable and should get it saved in case of accidental closing popover. Now such expressions can be executed in builder and will be compiled with undefined instead of variables in published sites. In the future we need to add global diagnostics to let users find such places faster. Also fixed a couple of ui issues - react error about using button inside of button in data variables list - react error about using unknown middlewareData prop from floating-ui
johnsicili
approved these changes
Jan 27, 2025
kof
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4768 #4753
User can paste expression with not defined variable and should get it saved in case of accidental closing popover.
Now such expressions can be executed in builder and will be compiled with undefined instead of variables in published sites.
In the future we need to add global diagnostics to let users find such places faster.
Also fixed a couple of ui issues