Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support expressions copy paste between instances #4790

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

TrySound
Copy link
Member

Ref #4768

Here improved copy paste experience between expressions. All expressions while editing have are no longer encoded with ids. For example system.search.name is the same.
Though invalid js characters are encoded with code point like this Collection Item.title becomes Collection$32$Item.title when copy into textual editor.

And this less obscure name can be copied between different lists with the same Collection Item name.

Verified

This commit was signed with the committer’s verified signature.
pioug Gilles Piou
Ref #4768

Here improved copy paste experience between expressions.
All expressions while editing have are no longer encoded with ids.
For example `system.search.name` is the same.
Though invalid js characters are encoded with code point like this
`Collection Item.title` becomes `Collection$32$Item.title` when copy
into textual editor.

And this less obscure name can be copied between different lists with
the same variable name.
@TrySound TrySound requested review from kof and johnsicili January 26, 2025 13:57

Verified

This commit was signed with the committer’s verified signature.
pioug Gilles Piou
@TrySound TrySound changed the title feat: match variables by name when copy paste feat: support expressions copy paste between instances Jan 26, 2025

Verified

This commit was signed with the committer’s verified signature.
pioug Gilles Piou

Verified

This commit was signed with the committer’s verified signature.
pioug Gilles Piou
@johnsicili
Copy link
Contributor

Nice I like it

@TrySound TrySound merged commit bc5d295 into main Jan 27, 2025
15 checks passed
@TrySound TrySound deleted the expressions branch January 27, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants