Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reuse help menu #4769

Merged
merged 6 commits into from
Jan 21, 2025
Merged

chore: Reuse help menu #4769

merged 6 commits into from
Jan 21, 2025

Conversation

kof
Copy link
Member

@kof kof commented Jan 21, 2025

Description

image
  1. Added central place for all help links
  2. Added same thing to the menu
  3. Deemphasize github discussions, it works better with discord for everything

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from johnsicili January 21, 2025 15:50
@kof kof changed the title chore: Reuse help men chore: Reuse help menu Jan 21, 2025
@kof kof merged commit aa8a720 into main Jan 21, 2025
15 checks passed
@kof kof deleted the help branch January 21, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants