refactor: replace image-size with image-meta #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image-size is barely supported, works only in node.js. Image-meta is a fork from unjs community, without dependencies, can work in browsers, we already use it inside of ipx.
|
They copied code from the original package without even mentioning it in the readme ... red flag!!! |
|
essentially they just copied one function and made it a separate package that works with streams, image-size has the same function to work with a buffer + has a fs api, that's why you thought its node only |
|
image-size also had comits just last month |
|
I think this behavior is shameless from image-meta authors |
|
Mentioned in license, all good |
kof
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image-size is barely supported, works only in node.js.
Image-meta is a fork from unjs community, without dependencies, can work in browsers, we already use it inside of ipx.