Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dashboard redesign #4757

Merged
merged 30 commits into from
Jan 20, 2025
Merged

feat: Dashboard redesign #4757

merged 30 commits into from
Jan 20, 2025

Conversation

kof
Copy link
Member

@kof kof commented Jan 17, 2025

Closes #4430

Todo

  • Better empty state in projects
  • Opening some of those things like video tutorials or support hub in an iframe directly in the dashboard
  • Search
  • published domain

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from istarkov and johnsicili January 20, 2025 10:04
@kof kof marked this pull request as ready for review January 20, 2025 10:05
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar should be sticky/fixed IMO.

One of the annoying things about the current dashboard is it doesn't show the custom domains if added. This A) helps indicate which sites are prod and B) can get you directly to the prod site

The discord icon looks weird as an outline
Screenshot 2025-01-20 at 6 17 25 AM

User dropdown is on the edge of the viewport
Screenshot 2025-01-20 at 6 17 57 AM

@kof
Copy link
Member Author

kof commented Jan 20, 2025

@johnsicili great catches

@kof
Copy link
Member Author

kof commented Jan 20, 2025

Sticky navigation and header - done

@johnsicili
Copy link
Contributor

Looks good. I like the fixed header too

Noticed this:
Screenshot 2025-01-20 at 9 38 51 AM

@johnsicili
Copy link
Contributor

johnsicili commented Jan 20, 2025

Screenshot 2025-01-20 at 9 39 44 AM

Fixed stays on top

@kof
Copy link
Member Author

kof commented Jan 20, 2025

@johnsicili fixed the bugs, updated the discord icon

@kof kof merged commit 70a57ff into main Jan 20, 2025
15 checks passed
@kof kof deleted the dash branch January 20, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize dashboard template images
4 participants