-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add head component #4751
Merged
Merged
feat: Add head component #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Jan 16, 2025
66fb943
to
9014ade
Compare
TrySound
reviewed
Jan 18, 2025
Probably we need to show it as absolute element above content. So it will not break the existing layout |
TrySound
reviewed
Jan 18, 2025
fixtures/webstudio-custom-template/app/routes/[script-test]._index.tsx
Outdated
Show resolved
Hide resolved
Background fixed now white |
TrySound
reviewed
Jan 18, 2025
TrySound
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows Head component
Hidden under
headSlotComponent
flagVercel fixture now have a HTMLRewriter example. Improves development.
Todo In Next PR
Head Title support
Icons
Allow reset
as
field- BG is now white always
- It's shown as fixed element to not break layout
Implementation details
This component has more priority above PageSettings meta tags
e.g. If some tag exists in PageSettings and in HeadSlot the HeadSlot wins
Steps for reproduction
Create HeadSlot
check server response.
See
og:title
is not duplicated.See no duplicated. All tags exists.
- Click Home.
See no meta tags are in Elements panel from
/head-tag
page- Click back button
See all meta is rendered and is not duplicated.
Code Review
Before requesting a review
Before merging
.env
file