Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Scroll into view doesn't work any more for scrollable divs #4674

Merged
merged 9 commits into from
Dec 30, 2024
Merged

fix: Scroll into view doesn't work any more for scrollable divs #4674

merged 9 commits into from
Dec 30, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 30, 2024 •
edited
Loading

Description

closes #4631

tested in Safari, FF, Chrome

TODO:

  • - Menu content cause
image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested review from kof and TrySound December 30, 2024 08:01
kof
kof requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@kof kof left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added swiper template and clicking on those content areas still doesn't scroll https://p-9b2603c4-d3cb-49d6-9fe2-85a3f1678891-dot-fix-scroll.development.webstudio.is/?pageId=DgdAm2lPUAwdgekIHZrpI

@istarkov istarkov requested a review from kof December 30, 2024 16:01
@istarkov istarkov merged commit 2c7cfb7 into main Dec 30, 2024
15 checks passed
@istarkov istarkov deleted the fix-scroll branch December 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll into view doesn't work any more for scrollable divs
3 participants
@istarkov @kof @TrySound