Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemap Index - Unexpected Server Error #4695

Closed
ryangorley opened this issue Jan 2, 2025 · 4 comments · Fixed by #4713
Closed

Sitemap Index - Unexpected Server Error #4695

ryangorley opened this issue Jan 2, 2025 · 4 comments · Fixed by #4713
Assignees
@istarkov
Labels
complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on type:bug Something isn't working

Comments

@ryangorley
Copy link

When I publish a sitemap index XML page structured like so I get an unexpected server error message:

<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
  <sitemap>
    <loc>https://davidsteedco.com/sitemap-current.xml</loc>
  </sitemap>
  <sitemap>
    <loc>https://davidsteedco.com/sitemap-sold-1.xml</loc>
  </sitemap>
  <sitemap>
    <loc>https://davidsteedco.com/sitemap-sold-2.xml</loc>
  </sitemap>
  <sitemap>
    <loc>https://davidsteedco.com/sitemap-sold-3.xml</loc>
  </sitemap>
</sitemapindex>

This is currently published (or should be at least) to https://davidsteedco.com/sitemap.xml. The error occurs on any URL I set the index to be. Dynamically generated and static values have both been tried.

(Just for reference I am attempting to achieve the XML structure specified by Google)
@kof
Copy link
Member

kof commented Jan 2, 2025

Can you repro it on a separate project that you can share with view permissions?

@ryangorley
Copy link
Author

ryangorley commented Jan 2, 2025 •
edited
Loading

@kof Sure! Here you go: https://p-df5ed58e-e96a-4082-8eca-33ca946adba8.apps.webstudio.is/?authToken=8c04bd93-4cb0-4bb5-b70a-edefd1082a5f&mode=preview

Here is the publish location displaying the same issue: https://xml-test-zczcn.wstd.io/sitemap.xml

If you need greater access please let me know. Thanks for looking into the issue!

@kof kof added type:bug Something isn't working complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on labels Jan 2, 2025
@kof
Copy link
Member

kof commented Jan 2, 2025

Thanks for the repro, you have a space in the tag name, please delete it. We will trim those as a fix for the future users

image

@ryangorley
Copy link
Author

Wow @kof . 🤦 Thank you.

@istarkov istarkov mentioned this issue Jan 4, 2025
Merged
7 tasks
istarkov added a commit that referenced this issue Jan 4, 2025
@istarkov
fix: Sitemap Index - Unexpected Server Error (#4713)
18aa8fd 
## Description

closes #4695
Also allow link in xml
closes #4401

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@istarkov istarkov

Labels
complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Sitemap Index - Unexpected Server Error webstudio-is/webstudio
3 participants
@kof @istarkov @ryangorley