shim away RTCSessionDescription/RTCIcecandidate #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically #266 but separate so it doesn't collide with #288 This is still required in Chrome 51, even though not if promises are used. See [here](https://bugs.chromium.org/p/chromium/issues/detail?id=612118)
|
LGTM. One thing though, we should have test that catch this. I will start looking at separating the tests into separate files per API since it's way too big now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically #266 but separate so it doesn't collide with #288
This is still required in Chrome 51, even though not if promises are used. See here
cc @jan-ivar, sorry for breaking this