Disable console logging by default #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns off logging to the
console
by default. Logging can still be re-enabled by callingadapter.disableLog(false)
.Resolves https://github.com/webrtc/adapter/issues/68.
Purpose
Logging by default is not desirable functionality. For an example of not logging to the console being standard convention, see this linting rule from ESLint: http://eslint.org/docs/rules/no-console. Here is an excerpt:
As such, having logging enabled by default in
adapter.js
(which therefore logs the first "switch" statement of code in the browser, without the ability to turn it off) is fairly bad non-standard practice, and it requires editing the source or forking the project before using the code in production. The adapter code should be as widely usable as possible (and of course designed for the browser), so logging should be off by default.