Skip to content

Commit

Permalink
Closing mdns agent
Browse files Browse the repository at this point in the history
I use the library with many open/close, and I get mdns storms where the webrtc library searches for other nodes over the network in a very aggressive manner.

This has been proposed by @r-byondlabs, and might very well be the problem: if I open/close many connections, and the mdns-agents are not cleaned up, there might be many requests.

Fixes #616
  • Loading branch information
ineiti authored Nov 20, 2024
1 parent fc3a0aa commit 9e262bb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ice/src/agent/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,8 @@ impl Agent {
udp_mux.remove_conn_by_ufrag(&ufrag).await;
}

self.close_multicast_conn(self.mdns_conn).await;

//FIXME: deadlock here
self.internal.close().await
}
Expand Down

0 comments on commit 9e262bb

Please sign in to comment.