Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify search template buttons #801

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Modify search template buttons #801

merged 3 commits into from
Jan 25, 2023

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Jan 23, 2023

Description

This PR modifies the search template's button colors for readability/UX purposes, and replaces the "Clear Options" button with a "Reset" button that clears both the search options and the URL search box.

Screenshots (if appropriate):

Before:

image

After:

Screen Shot 2023-01-23 at 5 30 28 PM

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l changed the title Search form Modify search template buttons Jan 23, 2023
@tw4l tw4l requested a review from ikreymer January 23, 2023 22:32
@krakan
Copy link
Contributor

krakan commented Jan 24, 2023

Nice!

@tw4l tw4l merged commit 9bc8a2e into main Jan 25, 2023
@tw4l tw4l deleted the search-form branch January 25, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants