Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin werkzeug version to 1.0.1. Fix #704 #705

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

rhenanbartels
Copy link
Contributor

Description

Motivation and Context

Fixes #704

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@Unip0rn
Copy link

Unip0rn commented Apr 4, 2022

I tested the fixed version for werkzeug but the error stays for me.
Environment is virtualenv -p python3 on Debian 11
Steps to reproduce:

  1. create virtualenv with -p python3 specified
  2. clone repo
  3. fix the version of the dependancy werkzeug to 1.0.1
  4. inside the virtualenv from 1. run python setup.py install
  5. inside the virtualenv from 1. run wayback

In any case thank you for your work, :)

@rhenanbartels rhenanbartels changed the title Ping werkzeug version to 1.0.1. Fix #704 Pin werkzeug version to 1.0.1. Fix #704 Apr 5, 2022
@ikreymer
Copy link
Member

Thanks! Can confirm this appears to be working.

@ikreymer ikreymer merged commit 63ac82e into webrecorder:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 / 3.9 dependency problems (werkzeug / gevent/greenlet)
3 participants