New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Redis Sentinels. #1

Open

abacaphiliac wants to merge 1 commit into master from add-sentinel-support

abacaphiliac commented Dec 16, 2016

DO NOT MERGE

there are some shady opinions in here and i'm not sure if the LaunchDarkly team will like them or want any of them.

ignore all composer.lock files
add min and max dependency version builds via travis (i know how to use travis-ci, not circle-ci)
allow for newer versions of Predis (for Sentinel support)
add Sentinel integration test
add PHPUnit config (for whitelist and coverage reports)
add default and Sentinel Predis Client factories
add Launch Darkly and Predis Client options objects
add unit tests over new components

@kpankonen i need help with the integration test. are you able and willing to assist?


          add support for Redis Sentinels.

a60fafd

kpankonen commented Dec 16, 2016

i'd love to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet