fix: allow more client options to be configured via resource url (#4156)

[jnu]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Yes, added tests for parsing resource query options

Motivation / Use-Case

See #4156

Breaking Changes

No breaking changes.

Additional Info

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Joe Nudell (77bf949)

[jnu]

ok sure, I will update this afternoon. thanks!

…

On Tue, Jan 11, 2022 at 9:20 AM Alexander Akait ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In client-src/index.js <#4157 (comment)> : > @@ -58,6 +58,18 @@ if (parsedResourceQuery["live-reload"] === "true") { log.info("Live Reloading enabled."); } +if (parsedResourceQuery.progress === "true") { + options.progress = true; + + log.info("Progress reporting enabled."); +} + +if (parsedResourceQuery.overlay === "true") { + options.overlay = true; + + log.info("Error overlay enabled."); +} I think we can use JSON.stringify/JSON.parse to support more options — Reply to this email directly, view it on GitHub <#4157 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIFGS3DDWUOTOQIK45M6TLUVRREVANCNFSM5LKWM5WA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[codecov]

Codecov Report

Merging #4157 (905df83) into master (b2202b6) will increase coverage by 0.21%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #4157      +/-   ##
==========================================
+ Coverage   92.27%   92.49%   +0.21%     
==========================================
  Files          14       14              
  Lines        1541     1558      +17     
  Branches      590      598       +8     
==========================================
+ Hits         1422     1441      +19     
+ Misses        110      108       -2     
  Partials        9        9              

Impacted Files	Coverage Δ
client-src/index.js	82.17% <82.35%> (+4.49%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2202b6...905df83. Read the comment docs.

[snitin315]

I believe we also need to set these options automatically if provided in configuration, as we do for other client options like logging.

webpack-dev-server/lib/Server.js

Line 596 in e99c0bc

if (typeof client.logging !== "undefined") {