Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added types for few utility methods #2172

Closed

Conversation

anikethsaha
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

NA

Motivation / Use-Case

Follow up of #2107

Breaking Changes

NA

Additional Info

Added types for

lib/utils/colors.js
lib/utils/createCertificate.js
lib/utils/createConfig.js

and added these files in tsconfig, will change the include in tsconfig to lib/utils/* once all of the files there is completed

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #2172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2172   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          34       34           
  Lines        1297     1297           
  Branches      370      370           
=======================================
  Hits         1216     1216           
  Misses         79       79           
  Partials        2        2
Impacted Files Coverage Δ
lib/utils/createCertificate.js 100% <ø> (ø) ⬆️
lib/utils/createConfig.js 96.46% <ø> (ø) ⬆️
lib/utils/colors.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7852f05...feca2c7. Read the comment docs.

@alexander-akait
Copy link
Member

Need fix CI problems 👍

mistic
mistic previously approved these changes Aug 2, 2019
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than CI lgtm

@anikethsaha
Copy link
Member Author

Not sure with where/why CI is failing. Need help with it !

@anikethsaha
Copy link
Member Author

@hiroppy done 👍

@anikethsaha
Copy link
Member Author

cc @evilebottnawi @hiroppy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants