Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the console path #95

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

theofidry
Copy link
Collaborator

Outside of a Symfony app the bin/console path does not make sense. Most of the time however, the script path remains unchanged between the main and child processes so we can make use of that instead.

This change means however that during the tests script path is no longer valid (it is a problem only for child processes) but this can easily be solved by explicitly declaring the script path.

Besides this change:

  • Rename the getConsolePath() to getScriptPath() which is a more generic name which is more fitting when working outside of a Symfony app
  • Move the validation of the script path outside of ParallelExecutor

@theofidry theofidry enabled auto-merge (squash) October 1, 2022 19:44
@theofidry theofidry merged commit f84da93 into webmozarts:master Oct 1, 2022
@theofidry theofidry deleted the feature/console-path branch October 1, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant