Simplify the passed environment variables #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we had those environment variables because they were needed for the child process to behave correctly. As of #28, this is no longer needed.
It is still a nice extension point to have, but at the very least we no longer need to give it the container as we currently do.
For this reason, in this PR:
ContainerInterfacefrom thegetEnvironmentVariables()methodgetEnvironmentVariables()togetExtraEnvironmentVariables()to better convey that they are not the only environment variables passed downnull. In practice there is no difference with[], but the code path followed is slightly simpler whennullis given.