Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the logger as a runtime parameter #90

Merged
merged 1 commit into from
Oct 1, 2022

Conversation

theofidry
Copy link
Collaborator

When working on a web app, it is common to declare the logger as a service registered to the container and use it like another service. For console commands however, this is not working as well. Indeed your logger may depend of the output for example, in which case it cannot be passed to the command as a regular service.

For this reason I am now passing the logger as a "runtime parameter" alongside the IO objects.

@theofidry theofidry merged commit 8120da7 into webmozarts:master Oct 1, 2022
@theofidry theofidry deleted the runtime-logger branch October 1, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant