Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error handler #88

Merged
merged 5 commits into from
Oct 1, 2022
Merged

Conversation

theofidry
Copy link
Collaborator

Back when we were confronted with the issue of error handling we settled for a quick and easy solution. This current solution has several flaws:

  • It has some Container (i.e. incompatible with non Symfony app) dependent code
  • It offers no convenient extension point
  • Offers toggled global based behaviour which in this peculiar instance is not inherently bad but is not ideal neither

For this reason I'm introducing an error handler interface. This offers a better extension point and clearer code as well. The current implementation aims to stay in line with the existing behaviour.

Note that a bug has been fixed which is that current the Container was never reset even if resettable (due to class_exists() returning false – should be interface_exists()).

@theofidry theofidry enabled auto-merge (squash) October 1, 2022 14:47
@theofidry theofidry disabled auto-merge October 1, 2022 14:47
@theofidry theofidry merged commit 5e633cc into webmozarts:master Oct 1, 2022
@theofidry theofidry deleted the feature/cleanup branch October 1, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant