Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forwarding options #81

Merged
merged 4 commits into from
Oct 1, 2022

Conversation

theofidry
Copy link
Collaborator

Currently we are using $input->getOptions(). It turns out it is not a good idea since when doing so it adds the default values of the options registered in the input definition. This is a problem as:

  • Those added options may not be necessary (from a user perspective it's redundant)
  • Those options includes "special options": options that are handled in a different way in Symfony*

*: Example of such a special option. When adding --version when calling your command, the Symfony application will directly handle it calling Application::getLongVersion() (in Application::doRun()) and not call the command at all.

@theofidry theofidry merged commit 42e5ea7 into webmozarts:master Oct 1, 2022
@theofidry theofidry deleted the bugfix/negatable-options branch October 1, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant