-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 5 compatibility: new Symfony\Component\Process\Process() only accepts an array #48
Conversation
Arrays are supported by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would love to see Symfony 5 support there!
Co-authored-by: Christian Fasching <fashxp@users.noreply.github.com>
@theofidry this PR would be ready 4 review now 😊 Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the ProcessLauncher
change
Thank you @brusch |
Thanks for reviewing & merging 😊 |
No description provided.