Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 5 compatibility: new Symfony\Component\Process\Process() only accepts an array #48

Merged
merged 5 commits into from
Mar 8, 2021

Conversation

brusch
Copy link
Contributor

@brusch brusch commented Feb 4, 2021

No description provided.

@brusch
Copy link
Contributor Author

brusch commented Feb 4, 2021

Arrays are supported by 3.4 as well, so should be fine and compatible.
See https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Process/Process.php#L284

Copy link

@fashxp fashxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would love to see Symfony 5 support there!

brusch and others added 2 commits March 2, 2021 10:46
Co-authored-by: Christian Fasching <fashxp@users.noreply.github.com>
@brusch
Copy link
Contributor Author

brusch commented Mar 2, 2021

@theofidry this PR would be ready 4 review now 😊 Thanks a lot!

Copy link
Collaborator

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the ProcessLauncher change

@theofidry theofidry merged commit dc6a871 into webmozarts:master Mar 8, 2021
@theofidry
Copy link
Collaborator

Thank you @brusch

@brusch
Copy link
Contributor Author

brusch commented Mar 8, 2021

Thanks for reviewing & merging 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants