Dropped PHP 7.2 support & added Travis config for PHP 8.0 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't support PHP 8 yet, but should be fine to run under PHP 8
brusch
commented
Nov 30, 2020
brusch
commented
Nov 30, 2020
|
@webmozart should be ready now (PHP |
|
Hi @brusch, sorry couldn't check your PR sooner. I think we will have to move to GitHub Actions first since Travis kinda dropped OSS support. If that helps though I don't mind to allow PHP8 in the composer.json although it would be at your own risks since we cannot test this at the moment |
|
@theofidry I think it's fine, I haven't experienced any problems so far. So yes, would be nice to have that merged. |
theofidry
reviewed
Jan 7, 2021
I think we can keep it |
|
Thanks! |
|
Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.