Introduce an input class #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmozart
requested changes
May 21, 2020
theofidry
added a commit
that referenced
this pull request
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
This PR now depends on #30. It introduces the
Configurationobject which takes care of the values (domain) validation and calculation. This allows to provide type-safe parameters with calculations easy to test and a friendly validation.Original:
A constant pain with the Symfony configuration system is the complete lack of type safety. This is even more problematic in our case where we have some type juggling and calculation done.
This PR proposes to introduce an input class,
ParallelizationInputwhich:This allows to: