Use child processes even if number of processes is only one #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It now shows the full segment size. I'm not sure whether this makes more or less sense. Let me know |
theofidry
approved these changes
Feb 14, 2020
|
Thanks @christian-kolb! |
christian-kolb
deleted the
issue/14-running-child-processes-on-single-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #14
@theofidry Gave it a shot and I think I already have it. But I'm not happy with the test as it doesn't really check if a child process is used and I don't see how I can validate that at the moment. We could extend the existing output to the command to also include whether child processes are spawned or not. What do you think?