Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/issue 8398/main #8402

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Dev/issue 8398/main #8402

merged 3 commits into from
Jun 3, 2022

Conversation

hammzj
Copy link
Contributor

@hammzj hammzj commented Jun 3, 2022 •
edited by gitpod-io bot
Loading

Proposed changes

On my first PR #8399, I had the parameter as "networkType". It was supposed to be "netspeed".

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@hammzj hammzj mentioned this pull request Jun 3, 2022
Closed
1 task
christian-bromann
christian-bromann approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs label Jun 3, 2022
@christian-bromann christian-bromann merged commit b2efba3 into webdriverio:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hammzj @christian-bromann