Use WebDriver if Appium capabilities are found #6929
Merged
+48
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
added
the
needs-review
christian-bromann
force-pushed
the
cb-better-protocol-choice
branch
from
a72bf49 to
d5fb012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently if someone would run tests on mobile there are chances WebdriverIO would pick the devtools protocol even though there is no chance to establish that connection. This patch adds checks on mobile caps to better determine the protocol.
Types of changes
Checklist
Further comments
fixes #6214
Reviewers: @webdriverio/project-committers