Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setting download paths with browser.cdp() #5753

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

vipulgupta2048
Copy link
Contributor

@vipulgupta2048 vipulgupta2048 commented Aug 24, 2020

Proposed changes

Solves #5727
Added information, links, and code snippet on setting download paths in Devtools Service with browser.cdp() command.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

If this was tested or we can suggest other solutions, that be great too.

@christian-bromann

Added information, links and code snippet on setting download paths in Devtools Service with browser.cdp() command.
@jsf-clabot
Copy link

jsf-clabot commented Aug 24, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting request.

Co-authored-by: Christian Bromann <github@christian-bromann.com>
@vipulgupta2048
Copy link
Contributor Author

@christian-bromann Good to go 🚀

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Docs 📝 PRs that contain changes to the documentation label Aug 25, 2020
@christian-bromann christian-bromann merged commit 93d0b37 into webdriverio:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants