Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybook-wdio boilerplate to document #4935

Conversation

davidnguyen11
Copy link
Contributor

@davidnguyen11 davidnguyen11 commented Jan 3, 2020

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Reviewers: @webdriverio/technical-committee

@jsf-clabot
Copy link

jsf-clabot commented Jan 3, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #4935 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4935   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         210      210           
  Lines        5535     5535           
  Branches     1211     1211           
=======================================
  Hits         5503     5503           
  Misses         29       29           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e122e32...0b26b1e. Read the comment docs.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for building this boilerplate!

@christian-bromann christian-bromann added backport-requested PRs with this label are considered to be applied to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation labels Jan 3, 2020
@christian-bromann christian-bromann merged commit 808ba34 into webdriverio:master Jan 3, 2020
@christian-bromann christian-bromann added backported PRs with this label got backported to the last maintained version and removed backport-requested PRs with this label are considered to be applied to the last maintained version labels Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PRs with this label got backported to the last maintained version PR: Docs 📝 PRs that contain changes to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants