Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes calling toHexString on undefined gasPrice (#4903) #4940

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Apr 13, 2022

For e2e win tests of #4903 PR

* Fixes calling toHexString on undefined gasPrice

Fixes #4902
@jdevcs jdevcs added the 1.x 1.0 related issues label Apr 13, 2022
@jdevcs jdevcs self-assigned this Apr 13, 2022
@render
Copy link

render bot commented Apr 13, 2022

@jdevcs
Copy link
Contributor Author

jdevcs commented Apr 13, 2022

#4903 PR already has 3 approval for changes so merging into 1.x

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2161595510

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 265 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.3%) to 74.495%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 7 85.42%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 44 9.66%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 2155746686: 2.3%
Covered Lines: 3242
Relevant Lines: 4107

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants