-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build command #4848
Fix build command #4848
Conversation
Pull Request Test Coverage Report for Build 1983218666
💛 - Coveralls |
The e2e_windows CI step is broken due to the same inability to connect to Infura that holds up other PRs. |
This somehow was automatically closed, but #4861 supersedes this anyways |
Description
This partially addresses long-broken parts of the npm testing scripts this PR template requires that contributors complete.
It doesn't fully address all the issues (e.g. that docker is an undocumented dependency required to run the geth instamine script which is triggered by one of the commands below, but things get much farther along than they used to.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code. [This works better now, but still not 100%]npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.