WIP: e2e tests #2688
Closed
WIP: e2e tests #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originally based this off of the v1.x branch, working on rebasing it off of 1.0 |
nivida
added
Enhancement
Closed
szerintedmi
reviewed
Apr 16, 2019
| @@ -0,0 +1,3 @@ | |||
| FROM node | |||
There was a problem hiding this comment.
ganache is publishing docker images too: trufflesuite/ganache-cli
| const url = protocol + '://' + host + ':' + rpcPort; | ||
| return describe('Web3 integration tests for: ' + url, () => { | ||
| before(function(done) { | ||
| this.timeout(30000); |
There was a problem hiding this comment.
Is it waiting for the provider to be ready after container launch?
Wouldn't be better to just wait for the port to be open before start any tests? Here it may still assert if it's connected (e.g. web3.eth.net.isListening() )
Closed
|
I've closed this PR because of PR #2693 |
szerintedmi
reviewed
Apr 16, 2019
| @@ -19,6 +19,8 @@ | |||
| "docs": "cd docs; make html;", | |||
| "lint": "jshint *.js packages", | |||
| "test": "mocha; jshint *.js packages", | |||
| "e2e": "docker-compose down && docker-compose build && docker-compose run --entrypoint 'npm run e2e:mocha' test_runner", | |||
| "e2e:mocha": "mocha --recursive ./e2e/**/*.spec.js -R spec --exit", | |||
There was a problem hiding this comment.
I'm not sure of introducing a new testing framework. What's the reason?
I was struggling with the Jest magic in the project but adding yet an other framework might increase package complexity even more.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting the scaffolding of the e2e tests
Start of the work for #2682
Type of change
Checklist:
npm run testin the root folder with success and extended the tests if necessary.npm run buildin the root folder and tested it in the browser and with node.npm run dtslintin the root folder and tested that all my types are correct