webrtc: add setParameterOptions to sender.setParameters #43705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 18, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4643591
branch
from
790f5e2 to
9540005
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4643591
branch
from
9540005 to
73e87f5
Compare
adding a new RTCSetParameterOptions object which has a sequence of RTCEncodingOptions similar to WebCodecs VideoEncoderEncodeOptions https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions and its keyFrame flag. On the native side, this adds the request_key_frame flag to the RtpEncodingParameters. WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/286741 Spec PRs: w3c/webrtc-pc#2885 w3c/webrtc-extensions#167 Chromestatus feature: https://chromestatus.com/feature/5161082937409536 BUG=chromium:1354101 Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4643591 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1249577}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4643591
branch
from
73e87f5 to
a3ec949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a new RTCSetParameterOptions object which has a sequence of
RTCEncodingOptions similar to
WebCodecs VideoEncoderEncodeOptions
https://w3c.github.io/webcodecs/#dictdef-videoencoderencodeoptions
and its keyFrame flag.
On the native side, this adds the request_key_frame flag to the
RtpEncodingParameters.
WebRTC CL:
https://webrtc-review.googlesource.com/c/src/+/286741
Spec PRs:
w3c/webrtc-pc#2885
w3c/webrtc-extensions#167
Chromestatus feature:
https://chromestatus.com/feature/5161082937409536
BUG=chromium:1354101
Change-Id: I5bfe266eac5990b1921212babdee1af35edc4242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4643591
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <phancke@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1249577}