Don't clear adoptedStyleSheets when moving shadow root between document <-> template #26080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 12, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2464519
branch
2 times, most recently
from
749ac9e to
d238163
Compare
…nt <-> template As discussed in WICG/construct-stylesheets#133, it should be safe to keep the adoptedStyleSheets when the shadow root is moved between a document and a <template> within that document. We should still clear the adoptedStyleSheets when moving a shadow root between documents outside of that case (e.g. between iframes). I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/W5-EGUySQgc/m/HxrySSpsBAAJ Bug: 1111864 Change-Id: I803e75e6339f9228289188e4ed7d3f14c6e2432c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464519 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#822999}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2464519
branch
from
d238163 to
4d6bdab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in WICG/construct-stylesheets#133,
it should be safe to keep the adoptedStyleSheets when the shadow root
is moved between a document and a <template> within that document. We
should still clear the adoptedStyleSheets when moving a shadow root
between documents outside of that case (e.g. between iframes).
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/W5-EGUySQgc/m/HxrySSpsBAAJ
Bug: 1111864
Change-Id: I803e75e6339f9228289188e4ed7d3f14c6e2432c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464519
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822999}