Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: review followup #12662

Merged
merged 1 commit into from
Aug 24, 2018
Merged

HTML: review followup #12662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ test(t => {
t.add_cleanup(() => frame.remove());
assert_equals(frame.contentDocument.URL, "about:blank");
assert_equals(frame.contentWindow.location.href, "about:blank");
frame.contentDocument.open();
assert_equals(frame.contentDocument.open(), frame.contentDocument);
assert_equals(frame.contentDocument.URL, document.URL);
assert_equals(frame.contentWindow.location.href, document.URL);
}, "document.open() changes document's URL (fully active document)");
Expand All @@ -26,7 +26,7 @@ async_test(t => {

frame.onload = t.step_func_done(() => {
// Now childDoc is still active but no longer fully active.
childDoc.open();
assert_equals(childDoc.open(), childDoc);
assert_equals(childDoc.URL, blankURL);
assert_equals(childWin.location.href, blankURL);
});
Expand All @@ -40,6 +40,9 @@ test(t => {
t.add_cleanup(() => frame.remove());
const doc = frame.contentDocument;

// We do not test for win.location.href in this test due to
// https://github.com/whatwg/html/issues/3959.

// Right now the frame is connected and it has an active document.
assert_equals(doc.URL, "about:blank");

Expand All @@ -55,6 +58,9 @@ async_test(t => {
const frame = document.createElement("iframe");
t.add_cleanup(() => frame.remove());

// We do not test for win.location.href in this test due to
// https://github.com/whatwg/html/issues/3959.

frame.onload = t.step_func(() => {
const doc = frame.contentDocument;
// Right now the frame is connected and it has an active document.
Expand Down