Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: document.open() and document's URL (with fragments) #10817

Merged
merged 2 commits into from
Aug 29, 2018
Merged

HTML: document.open() and document's URL (with fragments) #10817

merged 2 commits into from
Aug 29, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented May 3, 2018 •
edited by wpt-pr-bot
Loading

@wpt-pr-bot wpt-pr-bot added the html label May 3, 2018
@wpt-pr-bot wpt-pr-bot requested review from ayg, jdm, jgraham and zqzhang May 3, 2018 11:09
@annevk
Copy link
Member Author

annevk commented May 3, 2018 •
edited
Loading

The interesting thing is that if you reload this frame, it'll use the original URL, so that is preserved somehow. What probably happens is that reloading is based in history entries (except in Safari, where reloading will give you nested <iframe>s until some limit is reached).

@annevk annevk mentioned this pull request May 3, 2018
Closed
@TimothyGu TimothyGu mentioned this pull request Jul 12, 2018
Closed
19 tasks
@TimothyGu TimothyGu self-assigned this Jul 31, 2018
@TimothyGu TimothyGu changed the title HTML: document.open() and document's URL HTML: document.open() and document's URL (with fragments) Aug 22, 2018
TimothyGu added a commit that referenced this pull request Aug 22, 2018
@TimothyGu @annevk
HTML: document.open() and document's URL
6be6491 
For whatwg/html#3946.

Adapts the basic test in
#10817 for a number of
advanced scenarios.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@TimothyGu TimothyGu mentioned this pull request Aug 22, 2018
Merged
TimothyGu added a commit that referenced this pull request Aug 23, 2018
@TimothyGu @annevk
HTML: document.open() and document's URL (#12636)
312d712 
For whatwg/html#3946.

Adapts the basic test in
#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
zcorpan pushed a commit that referenced this pull request Aug 27, 2018
@TimothyGu @annevk @zcorpan
HTML: document.open() and document's URL (#12636)
16c2eb8 
For whatwg/html#3946.

Adapts the basic test in
#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
TimothyGu added a commit to TimothyGu/html that referenced this pull request Aug 28, 2018
@TimothyGu
document.open(): remove fragment before propagating entry document's URL
064d435 
Fixes whatwg#2555.

Tests: web-platform-tests/wpt#10817
@TimothyGu TimothyGu mentioned this pull request Aug 28, 2018
Merged
@TimothyGu TimothyGu force-pushed the annevk/document-open-steps-url branch from 8783e81 to 110d907 Compare August 28, 2018 19:42
@wpt-pr-bot wpt-pr-bot requested review from domenic, foolip, sideshowbarker and zcorpan and removed request for ayg August 28, 2018 19:42
@annevk @TimothyGu
HTML: add test for document.open() and URL fragment
6b088b7 
For whatwg/html#3970.

Co-authored-by: Timothy Gu <timothygu99@gmail.com>
@TimothyGu TimothyGu force-pushed the annevk/document-open-steps-url branch from 110d907 to 6b088b7 Compare August 28, 2018 19:45
domenic
domenic approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url-fragment.window.js Outdated
assert_equals(frame.contentWindow.location.href, urlSansHash);
});
self.location.hash = "heya";
}, "document.open() and document's URL containing a fragment");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "entry is not relevant" label

html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url-fragment.window.js Outdated
assert_equals(afterURL, frame.src);
assert_equals(frame.contentDocument.URL, frame.src);
});
}, "document.open() and document's URL containing a fragment (entry is current)");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/current/relevant as that's what the spec tests

html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url-fragment.window.js
window.testDone = t.step_func_done((beforeURL, afterURL) => {
assert_equals(beforeURL, frame.src);
assert_equals(afterURL, frame.src);
assert_equals(frame.contentDocument.URL, frame.src);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test location.href in this test too?

annevk pushed a commit to whatwg/html that referenced this pull request Aug 29, 2018
@TimothyGu @annevk
document.open(): remove fragment before propagating entry document's URL
ae688ea 
This is another part of the effort to overhaul document.open() as outlined in #3818.

Tests: web-platform-tests/wpt#10817.

Fixes #2555.
@annevk annevk merged commit d2cffc6 into master Aug 29, 2018
@annevk annevk deleted the annevk/document-open-steps-url branch August 29, 2018 07:28
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 29, 2018
@TimothyGu @moz-wptsync-bot
Bug 1485521 [wpt PR 12636] - HTML: document.open() and document's URL…
9ae5417 
…, a=testonly

Automatic update from web-platform-testsHTML: document.open() and document's URL (#12636)

For whatwg/html#3946.

Adapts the basic test in
web-platform-tests/wpt#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
--

wpt-commits: 312d71258a26bfa420f7eef100df4ef92d961483
wpt-pr: 12636
jankeromnes pushed a commit to jankeromnes/gecko that referenced this pull request Aug 29, 2018
@TimothyGu @moz-wptsync-bot
Bug 1485521 [wpt PR 12636] - HTML: document.open() and document's URL…
0b42256 
…, a=testonly

Automatic update from web-platform-testsHTML: document.open() and document's URL (#12636)

For whatwg/html#3946.

Adapts the basic test in
web-platform-tests/wpt#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
--

wpt-commits: 312d71258a26bfa420f7eef100df4ef92d961483
wpt-pr: 12636
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
@TimothyGu @mustaqahmed
document.open(): remove fragment before propagating entry document's URL
dabfd01 
This is another part of the effort to overhaul document.open() as outlined in whatwg#3818.

Tests: web-platform-tests/wpt#10817.

Fixes whatwg#2555.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
@TimothyGu @mustaqahmed
document.open(): remove fragment before propagating entry document's URL
07f4642 
This is another part of the effort to overhaul document.open() as outlined in whatwg#3818.

Tests: web-platform-tests/wpt#10817.

Fixes whatwg#2555.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1485521 [wpt PR 12636] - HTML: document.open() and document's URL…
d0fc3e8 
…, a=testonly

Automatic update from web-platform-testsHTML: document.open() and document's URL (#12636)

For whatwg/html#3946.

Adapts the basic test in
web-platform-tests/wpt#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: 312d71258a26bfa420f7eef100df4ef92d961483
wpt-pr: 12636

UltraBlame original commit: 0aaff791b401b17dd832464bc94688c474a08ebc
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
@marco-c
Bug 1485521 [wpt PR 12636] - HTML: document.open() and document's URL…
90c3641 
…, a=testonly

Automatic update from web-platform-testsHTML: document.open() and document's URL (#12636)

For whatwg/html#3946.

Adapts the basic test in
web-platform-tests/wpt#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: 312d71258a26bfa420f7eef100df4ef92d961483
wpt-pr: 12636

UltraBlame original commit: 0aaff791b401b17dd832464bc94688c474a08ebc
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
@marco-c
Bug 1485521 [wpt PR 12636] - HTML: document.open() and document's URL…
9a51c1e 
…, a=testonly

Automatic update from web-platform-testsHTML: document.open() and document's URL (#12636)

For whatwg/html#3946.

Adapts the basic test in
web-platform-tests/wpt#10817 for a number of
advanced scenarios regarding document activity.

Co-authored-by: Anne van Kesteren <annevkannevk.nl>
--

wpt-commits: 312d71258a26bfa420f7eef100df4ef92d961483
wpt-pr: 12636

UltraBlame original commit: 0aaff791b401b17dd832464bc94688c474a08ebc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

@foolip foolip Awaiting requested review from foolip

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

@zcorpan zcorpan Awaiting requested review from zcorpan

Assignees

@TimothyGu TimothyGu

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @domenic @TimothyGu @wpt-pr-bot