HTML: document.open() event listener removal #10686
Conversation
|
w3c-test:mirror |
| frame.contentDocument.addEventListener("x", t.unreached_func()); | ||
| body.addEventListener("x", t.unreached_func()); | ||
| frame.contentDocument.open(); | ||
| frame.contentDocument.close(); |
There was a problem hiding this comment.
The "close()" here seems not great since if someone implemented close() as removing the event listeners the test would still pass.
| body = frame.contentDocument.body; | ||
| t.add_cleanup(() => frame.remove()); | ||
| frame.contentDocument.addEventListener("x", t.unreached_func()); | ||
| body.addEventListener("x", t.unreached_func()); |
There was a problem hiding this comment.
Adding descriptions to unreached_funcs makes test failures much easier to diagnose.
| assert_true(once); | ||
| }, "Event listeners are to be removed with immediate effect"); | ||
|
|
||
| test(t => { |
There was a problem hiding this comment.
Might be worth gating this behind an if (document.body.attachShadow) so browsers without shadow DOM don't get failures.
There was a problem hiding this comment.
I think that's bad practice. It makes it less clear what's going on. And have a varying number of tests between browsers, if that's what you're suggesting, seems even worse for tooling.
| let once = false; | ||
| frame.contentDocument.addEventListener("x", () => { | ||
| frame.contentDocument.open(); | ||
| frame.contentDocument.close(); |
Dependency in DOM: whatwg/dom#641. Tests: web-platform-tests/wpt#10686. Fixes #2302.
|
Depending on the browser the load event might not fire and therefore the harness will timeout. I'm planning on investigating that separately in #10239. (Made progress on some other bits today though.) |
Dependency in DOM: whatwg/dom#641. Tests: web-platform-tests/wpt#10686. Fixes whatwg#2302.
For whatwg/html#3653.