Fix lint errors

web-platform-tests · Feb 17, 2025 · 732450c · 732450c
1 parent 27a20e5
commit 732450c
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 23 deletions.
diff --git a/tools/webdriver/webdriver/bidi/modules/web_extension.py b/tools/webdriver/webdriver/bidi/modules/web_extension.py
@@ -1,18 +1,18 @@
-from typing import Any, Mapping, MutableMapping
+from typing import Any, Mapping, MutableMapping, Optional
 
 from ._module import BidiModule, command
 
 class WebExtension(BidiModule):
     @command
-    def install(self, extensionData: Mapping[str, Any]) -> Mapping[str, Any]:
-        params: MutableMapping[str, Any] = { "extensionData": extensionData }
+    def install(self, extension_data: Mapping[str, Any]) -> Mapping[str, Any]:
+        params: MutableMapping[str, Any] = {"extensionData": extension_data}
         return params
 
     @install.result
-    def _install(self, result: Mapping[str, Any]) -> str:
+    def _install(self, result: Mapping[str, Any]) -> Optional[str]:
         return result.get("extension")
 
     @command
-    def uninstall(self, extension: str):
-        params: MutableMapping[str, Any] = { "extension": extension }
+    def uninstall(self, extension: str) -> Mapping[str, Any]:
+        params: MutableMapping[str, Any] = {"extension": extension}
         return params
diff --git a/webdriver/tests/bidi/web_extension/install/install.py b/webdriver/tests/bidi/web_extension/install/install.py
@@ -4,7 +4,7 @@
 @pytest.mark.asyncio
 async def test_install_from_base64(bidi_session, addon_data):
     web_extension = await bidi_session.web_extension.install(
-        extensionData={
+        extension_data={
             "type": "base64",
             "value": addon_data["base64"],
         }
@@ -19,7 +19,7 @@ async def test_install_from_base64(bidi_session, addon_data):
 @pytest.mark.asyncio
 async def test_install_from_path(bidi_session, addon_data):
     web_extension = await bidi_session.web_extension.install(
-        extensionData={
+        extension_data={
             "type": "path",
             "path": addon_data["path"],
         }
@@ -34,7 +34,7 @@ async def test_install_from_path(bidi_session, addon_data):
 @pytest.mark.asyncio
 async def test_install_from_archive_path(bidi_session, addon_data):
     web_extension = await bidi_session.web_extension.install(
-        extensionData={
+        extension_data={
             "type": "archivePath",
             "path": addon_data["archivePath"],
         }

diff --git a/webdriver/tests/bidi/web_extension/install/invalid.py b/webdriver/tests/bidi/web_extension/install/invalid.py
@@ -10,38 +10,38 @@
 async def test_params_extension_data_invalid_type(bidi_session, value):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData=value
+            extension_data=value
         )
 
 
 async def test_params_extension_data_invalid_value(bidi_session):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={}
+            extension_data={}
         )
 
 
 @pytest.mark.parametrize("value", [None, False, 42, {}, []])
 async def test_params_extension_data_type_invalid_type(bidi_session, value):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": value }
+            extension_data={ "type": value }
         )
 
 
 @pytest.mark.parametrize("value", ["", "unknown-type"])
 async def test_params_extension_data_type_invalid_value(bidi_session, value):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": value }
+            extension_data={ "type": value }
         )
 
 
 @pytest.mark.parametrize("value", ["path", "archivePath"])
 async def test_params_extension_data_path_missing(bidi_session, value):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": value }
+            extension_data={ "type": value }
         )
 
 
@@ -50,7 +50,7 @@ async def test_params_extension_data_path_missing(bidi_session, value):
 async def test_params_extension_data_path_invalid_type(bidi_session, data_type, value):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": data_type, "path": value }
+            extension_data={ "type": data_type, "path": value }
         )
 
 
@@ -59,50 +59,50 @@ async def test_params_extension_data_path_invalid_type(bidi_session, data_type,
 async def test_params_extension_data_path_invalid_value(bidi_session, data_type, value):
     with pytest.raises(error.UnknownErrorException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": data_type, "path": value }
+            extension_data={ "type": data_type, "path": value }
         )
 
 
 async def test_params_extension_data_archive_path_invalid_webextension(bidi_session, addon_data):
     with pytest.raises(error.InvalidWebExtensionException):
         await bidi_session.web_extension.install(
-            extensionData={"type": "archivePath",
+            extension_data={"type": "archivePath",
                            "path": addon_data["archivePathInvalid"]}
         )
 
 
 async def test_params_extension_data_path_invalid_webextension(bidi_session, addon_data):
     with pytest.raises(error.InvalidWebExtensionException):
         await bidi_session.web_extension.install(
-            extensionData={"type": "path", "path": addon_data["unsigned.xpi"]}
+            extension_data={"type": "path", "path": addon_data["unsigned.xpi"]}
         )
 
 
 async def test_params_extension_data_value_missing(bidi_session):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": "base64" }
+            extension_data={ "type": "base64" }
         )
 
 
 @pytest.mark.parametrize("value", [None, False, 42, {}, []])
 async def test_params_extension_data_value_invalid_type(bidi_session, value):
     with pytest.raises(error.InvalidArgumentException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": "base64", "value": value }
+            extension_data={ "type": "base64", "value": value }
         )
 
 
 async def test_params_extension_data_value_invalid_value(bidi_session):
     with pytest.raises(error.UnknownErrorException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": "base64", "value": "not a base64" }
+            extension_data={ "type": "base64", "value": "not a base64" }
         )
 
 
 @pytest.mark.parametrize("value", ["", "dGVzdA=="])
 async def test_params_extension_data_value_invalid_webextension(bidi_session, value):
     with pytest.raises(error.InvalidWebExtensionException):
         await bidi_session.web_extension.install(
-            extensionData={ "type": "base64", "value": value }
+            extension_data={ "type": "base64", "value": value }
         )
diff --git a/webdriver/tests/bidi/web_extension/uninstall/uninstall.py b/webdriver/tests/bidi/web_extension/uninstall/uninstall.py
@@ -5,7 +5,7 @@
 @pytest.mark.asyncio
 async def test_uninstall(bidi_session, addon_data):
     web_extension = await bidi_session.web_extension.install(
-        extensionData={
+        extension_data={
             "type": "base64",
             "value": addon_data["base64"],
         }