Alert component #45

jpellizzari · 2017-09-08T16:17:04Z

Adds an Alert component:

Also fixes some issues with <Button />:

Button was ignoring the style prop that is used in a couple places in Weave Cloud
Button would throw an error on click if no callback is provided. This props is optional.

…utton accept style prop

aaron7

lgtm - a few comments

src/components/Alert/Alert.js

+import styled from 'styled-components';
+import PropTypes from 'prop-types';
+
+const fromTheme = (component, field) => props => props.theme.atoms[component][props.type][field];


src/components/Alert/Alert.js

+  padding: 1em;
+  transition: opacity 0.2s linear;
+
+  .fa-remove {


src/components/Alert/Alert.test.js

+  });
+  it('closes when the "x" is clicked', () => {
+    const spy = jest.fn();
+    const alert = mount(withTheme(<Alert onClose={spy}>My alert</Alert>));


bowenli · 2017-09-08T17:11:50Z

lgtm

Fix Button throwing error when no onClick handler is provided; make b…

f8009a3

…utton accept style prop

jpellizzari requested review from aaron7 and bowenli September 8, 2017 16:17

aaron7 approved these changes Sep 8, 2017

View reviewed changes

Add Alert component

7c8b0df

jpellizzari force-pushed the alert-component branch from e46884e to 7c8b0df Compare September 8, 2017 18:25

jpellizzari merged commit 78b9243 into master Sep 8, 2017

jpellizzari deleted the alert-component branch September 8, 2017 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alert component #45

Alert component #45

jpellizzari commented Sep 8, 2017

aaron7 left a comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

bowenli commented Sep 8, 2017

Alert component #45

Alert component #45

Conversation

jpellizzari commented Sep 8, 2017

aaron7 left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

bowenli commented Sep 8, 2017