Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow to use v3 of auto-approve action #27

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Update workflow to use v3 of auto-approve action #27

merged 1 commit into from
Oct 17, 2022

Conversation

lelia
Copy link
Collaborator

@lelia lelia commented Oct 14, 2022 •
edited
Loading

Description

I contributed hmarr/auto-approve-action#205 to avoid deprecation errors when running node12 actions.

The fix was recently accepted by the maintainer, with a new v3 action release cut, so we should use that rather than my wayfair-contribs branch.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@lelia lelia requested review from GaryPWhite and draco2003 October 14, 2022 21:19
draco2003
draco2003 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@draco2003 draco2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lelia lelia merged commit ea1399d into main Oct 17, 2022
@lelia lelia deleted the update-auto-approve-action branch October 17, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draco2003 draco2003 draco2003 approved these changes

@GaryPWhite GaryPWhite Awaiting requested review from GaryPWhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lelia @draco2003