This repository was archived by the owner on Aug 2, 2023. It is now read-only.
#26 broke the build- fix histogram tests and keep compatibility with older golang versions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejelith
commented
Nov 11, 2021
•
bejelith
commented
- Build broke by Update Go modules and wavefront-sdk-go v0.9.8 #26 so had to change go.mod.
- Reworked tests to make more resilient in case of dependency changes.
bejelith
force-pushed
the
update_histogram_test
branch
4 times, most recently
from
4eb9648 to
7fab915
Compare
bejelith
force-pushed
the
update_histogram_test
branch
from
7fab915 to
2bf91ee
Compare
bejelith
changed the title
|
is there anybody working on this repository ? @joannak-vmware @vikramraman @laullon |
|
Hi @bejelith , I added myself as reviewer since I did the version bump, and will add an additional reviewer soon |
keep94
reviewed
Dec 8, 2021
| github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475 | ||
| github.com/stretchr/testify v1.7.0 | ||
| github.com/stretchr/testify v1.5.1 |
There was a problem hiding this comment.
Will you please explain why you can't use the latest version of testify?
There was a problem hiding this comment.
Their travis buils against very old versions of golang that do not support 1.7. the question is why are they still testing against golang 1.13?
keep94
approved these changes
Dec 9, 2021
joannatk
approved these changes
Dec 9, 2021
|
I cannot merge it as im not authorized |
|
@bejelith , have merged changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.