Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stack in Executor #1071

Merged
merged 8 commits into from
Jun 16, 2024
Merged

Use Stack in Executor #1071

merged 8 commits into from
Jun 16, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jun 15, 2024

This replaces the ValueStack and CallStack references with a single Stack reference in the Executor.

Robbepop added 2 commits June 15, 2024 12:48
This replaces the ValueStack and CallStack references with a single Stack reference.
This has severe performance implications on the Executor. Unfortunately in Rust 1.78 this regresses performance overall and in Rust 1.79 this improves performance all in all.
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 68.62745% with 16 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (3297811) to head (86b9f66).

Files Patch % Lines
crates/wasmi/src/engine/executor/instrs/call.rs 71.42% 6 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/return_.rs 61.53% 5 Missing ⚠️
crates/wasmi/src/engine/executor/instrs.rs 62.50% 3 Missing ⚠️
crates/wasmi/src/engine/executor/stack/mod.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
- Coverage   80.50%   80.47%   -0.03%     
==========================================
  Files         269      269              
  Lines       24970    24975       +5     
==========================================
- Hits        20101    20099       -2     
- Misses       4869     4876       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 56a15da into master Jun 16, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-use-stack-in-executor branch June 16, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant