Remove unused code and some unused annotations (#1077)

* remove unused code

* remove unused warnings allowances

* add comment to warning allowance

crates/wasmi/src/engine/executor/stack/calls.rs

@@ -34,9 +34,6 @@ pub struct CallStack {
 }
 
 impl CallStack {
-    /// Default value for the maximum recursion depth.
-    pub const DEFAULT_MAX_RECURSION_DEPTH: usize = 1024;
-
     /// Creates a new [`CallStack`] using the given recursion limit.
     pub fn new(recursion_limit: usize) -> Self {
         Self {

crates/wasmi/src/engine/executor/stack/mod.rs

@@ -29,17 +29,6 @@ pub struct Stack {
 }
 
 impl Stack {
-    #![allow(dead_code)]
-
-    /// Default value for the maximum recursion depth.
-    pub const DEFAULT_MAX_RECURSION_DEPTH: usize = CallStack::DEFAULT_MAX_RECURSION_DEPTH;
-
-    /// Default value for initial value stack height in bytes.
-    pub const DEFAULT_MIN_VALUE_STACK_HEIGHT: usize = ValueStack::DEFAULT_MIN_HEIGHT;
-
-    /// Default value for maximum value stack height in bytes.
-    pub const DEFAULT_MAX_VALUE_STACK_HEIGHT: usize = ValueStack::DEFAULT_MAX_HEIGHT;
-
     /// Creates a new [`Stack`] given the [`Config`].
     ///
     /// [`Config`]: [`crate::Config`]
@@ -70,15 +59,6 @@ impl Stack {
         }
     }
 
-    /// Returns `true` if the [`Stack`] is empty.
-    ///
-    /// # Note
-    ///
-    /// Empty [`Stack`] instances are usually non-usable dummy instances.
-    pub fn is_empty(&self) -> bool {
-        self.values.is_empty()
-    }
-
     /// Returns the capacity of the [`Stack`].
     pub fn capacity(&self) -> usize {
         self.values.capacity()

crates/wasmi/src/engine/executor/stack/values.rs

@@ -125,11 +125,6 @@ impl ValueStack {
         self.values.capacity()
     }
 
-    /// Returns `true` if the [`ValueStack`] is empty.
-    pub fn is_empty(&self) -> bool {
-        self.len() == 0
-    }
-
     /// Reserves enough space for `additional` cells on the [`ValueStack`].
     ///
     /// This may heap allocate in case the [`ValueStack`] ran out of preallocated memory.

crates/wasmi/src/engine/translator/tests/op/mod.rs

@@ -59,7 +59,7 @@ use std::format;
 ///
 /// If the `value` cannot be converted into `i32` losslessly.
 #[track_caller]
-#[allow(dead_code)]
+#[allow(dead_code)] // might be useful later
 fn i32imm16(value: i32) -> Const16<i32> {
     <Const16<i32>>::try_from(value)
         .unwrap_or_else(|_| panic!("value must be 16-bit encodable: {}", value))

crates/wasmi/src/func/into_func.rs

@@ -328,7 +328,6 @@ mod tests {
         marker: core::marker::PhantomData<fn() -> T>,
     }
     /// Utility trait for the fallback case of the `implements_wasm_results` macro.
-    #[allow(dead_code)] // TODO: somehow the tests work without this which is strange.
     pub trait ImplementsWasmRetFallback {
         const VALUE: bool = false;
     }
@@ -341,7 +340,6 @@ mod tests {
         // We need to allow for dead code at this point because
         // the Rust compiler thinks this function is unused even
         // though it acts as the specialized case for detection.
-        #[allow(dead_code)]
         pub const VALUE: bool = true;
     }
     /// Returns `true` if the given type `T` implements the `WasmRet` trait.

crates/wasmi/src/store.rs

@@ -684,7 +684,6 @@ impl StoreInner {
     ///
     /// - If the [`ElementSegment`] does not originate from this [`Store`].
     /// - If the [`ElementSegment`] cannot be resolved to its entity.
-    #[allow(unused)] // Note: We allow this unused API to exist to uphold code symmetry.
     pub fn resolve_element_segment(&self, segment: &ElementSegment) -> &ElementSegmentEntity {
         self.resolve(segment.as_inner(), &self.elems)
     }

fuzz/fuzz_targets/differential.rs

@@ -323,7 +323,6 @@ impl DifferentialTarget for Wasmtime {
     }
 }
 
-#[allow(dead_code)] // Note: dead code analysis somehow ignores Debug impl usage.
 #[derive(Debug, Default)]
 pub struct UnmatchedState {
     globals: Vec<UnmatchedGlobal>,