Add title when adding public keys

[moalshak]

This PR adds the title input as a field in the frontend and saves it in the DB.

A view from the modal:

Public key after being saved:

Working on this, I realized that we should probably add more metadata like when it was added, when it was last used etc.

Fixes: #714
Fixes: #754
Fixes: #898
Fixes: #1176

One thing to note is that my passwords manager stopped recognizing the public id field as one.

[Eugeny]

Thank you for the PR!

Working on this, I realized that we should probably add more metadata like when it was added, when it was last used etc.

That's a great idea - happy to merge if you're willing to work on this.

passwords manager stopped recognizing the public id field as one.

What does this mean?

[moalshak]

What does this mean?

My 1Password used to recognize the field as an ssh field and suggest adding my saved pub key in it.

[Eugeny]

Oh - I wonder what logic it uses to recognize it.

[moalshak]

Oh - I wonder what logic it uses to recognize it.

Not great logic tbh haha, since it thinks the title input is the ssh input on the https://github.com/settings/ssh/new page.

[moalshak]

@Eugeny The tests step seems to fail with the following trace:

20:32:05.854 ERROR Error during SonarScanner CLI execution
java.lang.IllegalStateException: Error status returned by url [https://api.sonarcloud.io/analysis/jres?os=linux&arch=x86_64]: 401
	at org.sonarsource.scanner.lib.internal.http.ScannerHttpClient.callUrl(ScannerHttpClient.java:163)
	at org.sonarsource.scanner.lib.internal.http.ScannerHttpClient.callApi(ScannerHttpClient.java:126)
	at org.sonarsource.scanner.lib.internal.http.ScannerHttpClient.callRestApi(ScannerHttpClient.java:104)
	at org.sonarsource.scanner.lib.internal.JavaRunnerFactory.getJreMetadata(JavaRunnerFactory.java:159)
	at org.sonarsource.scanner.lib.internal.JavaRunnerFactory.getJreFromServer(JavaRunnerFactory.java:138)
	at org.sonarsource.scanner.lib.internal.JavaRunnerFactory.createRunner(JavaRunnerFactory.java:85)
	at org.sonarsource.scanner.lib.internal.ScannerEngineLauncherFactory.createLauncher(ScannerEngineLauncherFactory.java:53)
	at org.sonarsource.scanner.lib.ScannerEngineBootstrapper.bootstrap(ScannerEngineBootstrapper.java:123)
	at org.sonarsource.scanner.cli.Main.analyze(Main.java:75)
	at org.sonarsource.scanner.cli.Main.main(Main.java:63)
20:32:05.855 ERROR

Is this something I can fix?

[Eugeny]

You can ignore the sonarqube error - however the migration is failing when there are existing keys in the database:

23:11:50 ERROR Fatal error error=Execution Error: error returned from database: (code: 1) Cannot add a NOT NULL column with default value NULL

[moalshak]

@Eugeny I fixed that (locally). However, I am running into issues now due to the name "label". In the user's view of the profile, that field was already being used for the abbreviated ssh key. See:

What do you propose to change ? The name from label to back to title ? Or the old label to abbreviation?

[Eugeny]

Let's change the old label to abbreviated

[Eugeny]

Looks good now - thanks!

@all-contributors add @moalshak for code