Expand emscripten support to supporting JS imported closures. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-yfyang
force-pushed
the
yfyang
branch
from
96fbb20 to
ff804ec
Compare
google-yfyang
force-pushed
the
yfyang
branch
from
ff804ec to
92e51fd
Compare
Notably, to work with emscripten, the emitted js has explicit dependencies listed for the imports.
google-yfyang
force-pushed
the
yfyang
branch
from
92e51fd to
c3a0e58
Compare
walkingeyerobot
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes the change to the interpreter's global get instruction to work with target triple
wasm32-unknown-emscripten.