Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #586
Description
It does so by introducing a simple (and optional) ping-like protocol for
nim-waku
that periodically sends an empty message to connected peers. This a temporary workaround untillibp2p
ping protocol has been implemented, as set out in vacp2p/nim-libp2p#567. Ping protocol is currently prioritised on the nim-libp2p side, but will likely not be finished before the planned testnet fornim-waku
. Waku v2 dogfooding has also commenced and somekeepalive
mechanism is necessary to maintain stable fleet connections and bridgetoy-chat
messages to Discord.How is this different from the
libp2p
ping protocol?It is simpler in at least two ways:
Limitations of this approach:
keepalive
will likely only be available once ping protocol is implemented.