feat(filter)!: better API for subscription: subscribe() abstracts createSubscription

[danisharora099]

#1979 (comment)

Problem

Solution

Notes

• Resolves
• Related to

Contribution checklist:

• covered by unit tests;
• covered by e2e test;
• add ! in title if breaks public API;

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
Waku node	119.35 KB (+0.09% 🔺)	2.4 s (+0.09% 🔺)	13 s (-22.27% 🔽)	15.4 s
Waku Simple Light Node	184.21 KB (+0.01% 🔺)	3.7 s (+0.01% 🔺)	23.5 s (+1.98% 🔺)	27.2 s
ECIES encryption	23.16 KB (+0.07% 🔺)	464 ms (+0.07% 🔺)	4.9 s (-24.73% 🔽)	5.3 s
Symmetric encryption	22.61 KB (+0.06% 🔺)	453 ms (+0.06% 🔺)	7.1 s (-3.33% 🔽)	7.5 s
DNS discovery	72.6 KB (+0.12% 🔺)	1.5 s (+0.12% 🔺)	13.9 s (+28.28% 🔺)	15.3 s
Peer Exchange discovery	74.49 KB (-0.04% 🔽)	1.5 s (-0.04% 🔽)	10.6 s (-4.81% 🔽)	12.1 s
Local Peer Cache Discovery	67.8 KB (+0.05% 🔺)	1.4 s (+0.05% 🔺)	9.1 s (-25.85% 🔽)	10.4 s
Privacy preserving protocols	38.91 KB (+0.1% 🔺)	779 ms (+0.1% 🔺)	12 s (+58.5% 🔺)	12.7 s
Waku Filter	113.75 KB (+0.22% 🔺)	2.3 s (+0.22% 🔺)	19.3 s (+19.63% 🔺)	21.5 s
Waku LightPush	111.66 KB (+0.01% 🔺)	2.3 s (+0.01% 🔺)	15.8 s (-21.85% 🔽)	18.1 s
History retrieval protocols	112.08 KB (-0.15% 🔽)	2.3 s (-0.15% 🔽)	19.3 s (+1.67% 🔺)	21.6 s
Deterministic Message Hashing	7.33 KB (-0.12% 🔽)	147 ms (-0.12% 🔽)	2.7 s (+87.74% 🔺)	2.8 s

[danisharora099]

closed in favor of #2092